Skip to content

[Chore] Use fictional placeholder data in test fixtures and dev examples - #192

Merged
mrubens merged 2 commits into
developfrom
chore/anonymize-internal-identifiers-338zn4faxjzbq
Jul 11, 2026
Merged

[Chore] Use fictional placeholder data in test fixtures and dev examples#192
mrubens merged 2 commits into
developfrom
chore/anonymize-internal-identifiers-338zn4faxjzbq

Conversation

@roomote-roomote

@roomote-roomote roomote-roomote Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @openmote, in the web UI, or in Slack.

What changed

Standardizes test fixtures, eval datasets, and dev-setup examples on clearly fictional placeholder data:

  • Slack test fixtures now use example.slack.com with placeholder channel/user IDs (C0EXAMPLE01 / U0EXAMPLE01) and generic message text.
  • ngrok hostnames in dev tooling fixtures use generic example hosts, and the R_PUBLIC_URL setup error in apps/dev/src/services/env.ts suggests https://your-ngrok-domain.ngrok.app, matching .env.local.example.
  • Entra tenant email examples in ADO/auth fixtures use fictional local parts. The roomote.* tenant domain shape is kept because the ADO regression tests specifically assert that humans in a roomote.* tenant are not matched as Roomote's own bot identity.
  • Person names in test and eval data are standardized on the fictional-name convention already used elsewhere in the repo (Ada Lovelace, Grace Hopper, Alan Turing, Edsger Dijkstra, Radia Perlman), with dependent assertions (avatar initials, analytics ordering keys, mock Slack user IDs, summary-prompt substrings) updated to match.

No production logic changes: outside tests and eval data, only a code comment and an error-message example string are touched.

How it was tested

  • Targeted Vitest runs for all affected test files across @roomote/api, @roomote/dev, @roomote/web, @roomote/worker, @roomote/ado, @roomote/communication, @roomote/sdk, @roomote/slack, and @roomote/cloud-agents — all pass.
  • pnpm lint and pnpm check-types pass.

Checklist

  • The PR title follows the repo convention: [Fix], [Feat], [Improve], [Refactor], [Docs], or [Chore] followed by a user-facing description
  • This PR is small and scoped to one change
  • pnpm lint and pnpm check-types pass locally
  • I added tests or included a clear manual validation note above
  • I removed secrets, tokens, private keys, and customer data from code, logs, and screenshots
  • If this change should appear in the changelog, I ran pnpm changeset (not needed: test-fixture and dev-example text only)

@roomote-roomote

roomote-roomote Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

No new code issues found — the latest commit resolves both previously flagged consistency issues, and the affected tests pass. See task

  • apps/api/src/handlers/tasks/__tests__/sendMessageToTask.test.ts:498 (and :552): the fixture user was renamed to Ada Lovelace but its email still reads matt@example.com, leaving Matt's first name in a file this PR touched and creating a mismatched name/email pair. Consider ada@example.com to match the rename and the PR's stated "zero residual personal email local parts". — resolved: both emails now ada@example.com.
  • packages/slack/evals/scenarios/slack-duplicate-delivery.json:29-31, packages/slack/evals/scenarios/slack-fast-answer.json:30-31, packages/slack/scripts/mock-slack.example.json:32-33: only displayName was anonymized to Grace Hopper while id: "UDAN" and name: "dan" remain, unlike mock-slack-server.test.ts which migrated the id (UGRACE) and handle (grace) too. This leaves the dan handle as a residual and makes the parallel fixtures inconsistent. — resolved: id/name/members migrated to UGRACE/grace; no residual UDAN/dan remain.

@roomote-roomote roomote-roomote Bot changed the title [Chore] Replace personal identifiers in test fixtures and dev examples with fictional values [Chore] Use fictional placeholder data in test fixtures and dev examples Jul 11, 2026
@mrubens
mrubens marked this pull request as ready for review July 11, 2026 15:16
@mrubens
mrubens merged commit 015a75b into develop Jul 11, 2026
1 check passed
@mrubens mrubens mentioned this pull request Jul 12, 2026
6 tasks
@mrubens
mrubens deleted the chore/anonymize-internal-identifiers-338zn4faxjzbq branch July 12, 2026 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant